search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 148 forks source link

Disable minio and mysql operators by default and move their crds to their folder #276

Closed ricosega closed 2 years ago

ricosega commented 2 years ago

Summary

Today I faced that I wanted to deploy the mattermost-operator in our Kubernetes cluster and as of k8s version 1.22 I couldn't. The cause of this are those crds which are part of minio-operator and mysql-operator found in crds/ folder, because they still use old apiVersion.

So, as they do not have to be applied always and only if the operators are enabled I moved them to their corresponding folder. Also and no less important, I set the operators as false by default, because they should be deployed separately in a production environment and only enabled for testing purposes as described in the documentation.

mattermod commented 2 years ago

Hello @ricosega,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @BenLloydPearson @aspleenic

ricosega commented 2 years ago

Hi @cpanato comments fixed now.

ricosega commented 2 years ago

@Szymongib @stylianosrigas can someone check this?