search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 150 forks source link

[MATTERMOST] helm charts - ApiVersion #280

Closed HujinoKun closed 2 years ago

HujinoKun commented 2 years ago

Hello,

Following a version upgrade on kubernetes to 1.22.

The _helper file is no longer good on the api version of the networking module.

Error : 

Error: UPGRADE FAILED: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1beta1"

Since 1.19, the networking.k8s.io/v1 api is available and it is native on version 1.22.

Could you add this to the _helper file: 

{{- if semverCompare "^1.19-0" .Capabilities.KubeVersion.GitVersion -}}
"networking.k8s.io/v1"
ghost commented 2 years ago

That wouldn't be sufficient, since v1 also adds some extra changes:

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

EugenMayer commented 2 years ago

@acuteaura is right, the current resource is not usable right now without fixing the actual structure / deprecations

theAkito commented 2 years ago

Is there at least an easy workaround available?

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:25:17Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:19:12Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
HujinoKun commented 2 years ago

Please, upgrade the helm charts with latest version of ingress