search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 148 forks source link

Feature/private registry #290

Closed patatman closed 2 years ago

patatman commented 2 years ago

Summary

PR makes it possible to pull operator images from a private registry, when needing to authenticate. Added additional field to supply a Secret name where the Registry Credentials are located in the namespace.

Documentation needs to be clarified a bit I think to make sure people don't make mistakes.

Ticket Link

Fixes https://github.com/mattermost/mattermost-helm/issues/233

mattermod commented 2 years ago

Hello @patatman,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

patatman commented 2 years ago

For some reason I can't seem to remove one of my commits, I've tried rebasing, but it keeps popping back. Maybe because of the change we did simultaneously? I needed to fetch my forked branch to make it work.

cpanato commented 2 years ago

For some reason I can't seem to remove one of my commits, I've tried rebasing, but it keeps popping back. Maybe because of the change we did simultaneously? I needed to fetch my forked branch to make it work.

you can rebase and then squash the commits, you can use the git rebase -i upstream/master to help the -i is interactive

cpanato commented 2 years ago

@patatman there is a lint failure

charts/mattermost-operator/values.yaml
  21:1      error    trailing spaces  (trailing-spaces)
patatman commented 2 years ago

I did a hard reset to master, and then just reapplied the changes. Looks like everything is clean now :)