search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 148 forks source link

Do not pass Chart version to deployment selectors #297

Closed Szymongib closed 2 years ago

Szymongib commented 2 years ago

Summary

Currently, the Chart version is passed to the value of one of the selector labels. The selector, however, is immutable therefore any bump to the chart version makes it impossible to upgrade the chart with helm upgrade.

This PR removes thehelm.sh/chart label from selector to fix this issue.

Ticket Link

https://mattermost.atlassian.net/browse/MM-41087

Szymongib commented 2 years ago

did you test the upgrade? To check if nothing will be lost?

As mentioned in the description upgrades do not work right now because of the selector, so for this change, you cannot upgrade either (deployment need to be manually deleted).

This PR should fix upgrades going forward.