mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 148 forks source link

Mattermost Teams Add support for Ingress networking.k8s.io/v1 apiVersion #298

Closed Serk72 closed 2 years ago

Serk72 commented 2 years ago

Add support for Ingress networking.k8s.io/v1 for mattermost teams chart. Ingress networking.k8s.io/v1 will only be used for kuberentes 1.19+ and old versions will maintain their current functionality.

Added instructions to readme for how to recover if the update to kubernetes 1.22 is done before running this chart update as the Ingress networking.k8s.io/v1beta1 is removed in this version.

mattermod commented 2 years ago

Hello @Serk72,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Serk72 commented 2 years ago

/check-cla

HujinoKun commented 2 years ago

It would be great if the modifications were taken into account on the main branch :)

eddycharly commented 2 years ago

+1 :)

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

JosefWN commented 2 years ago

+1

JosefWN commented 2 years ago

I think this can be closed now: https://github.com/mattermost/mattermost-helm/pull/322

Serk72 commented 2 years ago

The Readme changes may be nice to have still but yea with that pull request the main issue is fixed so I'll close this