Closed ruckc closed 2 years ago
Hello @ruckc,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
@stylianosrigas - can you look at this PR please?
@stylianosrigas - can you look at this PR please?
Thanks @ruckc for the PR. Can you fix the test failures? For every change you also need to bump the chart version. Adding @spirosoik and @pfltdv for review ;)
@pfltdv - should i bump the version also? that is why one of the lint-charts is failing
@pfltdv - should i bump the version also? that is why one of the lint-charts is failing
@ruckc It should not be a requirement for you since we are not generating a release. Looks like the versions at master branch need to be fixed. I will check, fix and notify you as soon as it is ready.
i should only need to bump the ee version since i didn't change team edition
Sorry about it. Yes it looks ok now.
@pfltdv / @stylianosrigas - when will this be merged?
Summary
This PR adds
extraEnv
array to the jobserver configuration in order to set various environment variables for mattermost.In short, when using an external postgres, with
driverName: postgres
, you can leave datasource as an empty string, and useextraEnv
to pass libpq environment variables to the mattermost process. Some of these can be pulled from secrets.Ticket Link
This PR partially addresses #140, when using an external postgresql database.
Values example
When using mattermost paired with Postgres Operator