search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 147 forks source link

fix-extraEnv-default-value #329

Open ruckc opened 2 years ago

ruckc commented 2 years ago

Summary

I messed up the default value for extraEnv in #316. This fixes the jobserver.extraEnv to be an array, which is what the template is expecting

Without this change, if trying to use jobserver's extraEnvs, you get this error:

cannot overwrite table with non table for mattermost-enterprise-edition.global.features.jobserver.extraEnv
mattermod commented 2 years ago

Hello @ruckc,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

ruckc commented 2 years ago

the tests need to be retried

ruckc commented 2 years ago

@spirosoik / @pfltdv / @stylianosrigas - can you review?

spirosoik commented 2 years ago

@pfltdv did you give a try to test locally?

ghost commented 2 years ago

@pfltdv did you give a try to test locally?

@spirosoik Yes tested with and without jobserver extra vars. Had no issue at both executions.

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

jonathanwiemers commented 2 years ago

@ruckc any reason this wasn't merged / updated anymore? Just saw that i've just create a PR for the same issue.

ruckc commented 2 years ago

@jonathanwiemers - no real reason, other than the 3 week lag on feedback. My need for this was removed as we moved away from mattermost due to the integration and license headaches.

spirosoik commented 1 year ago

/update-branch