search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 147 forks source link

Fixing Ingress support for k8s >v1.18 #338

Open maxirus opened 2 years ago

maxirus commented 2 years ago

Summary

Adds ingressClassName support.

Ticket Link

Fixes issue #337

mattermod commented 2 years ago

Hello @maxirus,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hcsaustrup commented 1 year ago

Let's get this merged! :-)

mjka-sclable commented 1 year ago

We're really looking forward to this feature. :) Is there anything were I can help to get this merged?

pablo-suazo commented 1 year ago

@maxirus could you sign the CLA? @hcsaustrup Is there anything we can do to have this merged? If we want to deploy mattermost in a cluster and we want to use a non-default ingress, at this point we need to deploy the Ingress using an additional manifest

maxirus commented 1 year ago

@maxirus could you sign the CLA? @hcsaustrup Is there anything we can do to have this merged? If we want to deploy mattermost in a cluster and we want to use a non-default ingress, at this point we need to deploy the Ingress using an additional manifest

Sorry, I do not sign CLAs that require PII as a condition of an OSS contribution. That said, I give anyone else permission to copy my changes and submit them as their own if they wish.