mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 147 forks source link

Added securityContext on mattermost-operator helm chart deployment #340

Closed frjaraur closed 10 months ago

frjaraur commented 2 years ago

Summary

Added securityContext on mattermost-operator helm chart deployment

Ticket Link

This just add securityContext on mattermost-operator helm chart deployment as discussed on https://github.com/mattermost/mattermost-helm/issues/339.

mattermod commented 2 years ago

Hello @frjaraur,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

spirosoik commented 1 year ago

@frjaraur thanks for your contribution. Could we fix the lint errors and rebase with latest master please?

frjaraur commented 1 year ago

Hi @spirosoik, I am reviewing right now, but I am not sure if lint is reporting just the chart release change. I changed Chart release to 0.3.2. Please let me know if this solves the problem (first time contributing to this project).

spirosoik commented 1 year ago

/update-branch

spirosoik commented 1 year ago

Hi @spirosoik, I am reviewing right now, but I am not sure if lint is reporting just the chart release change. I changed Chart release to 0.3.2. Please let me know if this solves the problem (first time contributing to this project).

you need to bump the version actually, there was already an update in the repo

frjaraur commented 1 year ago

I reviewed Chart release and upgraded to 0.3.3.

spirosoik commented 1 year ago

/update-branch

stylianosrigas commented 10 months ago

@frjaraur Thanks for the contribution and sorry it took some time to review and move forward. Can you please resolve the conflicts to merge the PR?

frjaraur commented 10 months ago

Done, let me know.