mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 147 forks source link

fix: using nintend for extraEnvs on JobServer #348

Closed jonathanwiemers closed 2 years ago

jonathanwiemers commented 2 years ago

Summary

Fixing an issue where resulting intention would be wrong on jobserver.extraEnv.
Problem is that all lines before have - which results in the first line of extraEnv is moved behind MM_CONFIG.valueFrom.secretKeyRef.key, resulting in a yaml error. Using nintend fixes this issue.

mattermod commented 2 years ago

Hello @jonathanwiemers,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

jonathanwiemers commented 2 years ago

@phoinixgrr i guess someone from your side has to merge it?

phoinixgrr commented 2 years ago

@stylianosrigas @AshishDhama @spirosoik
Let me know if there are any objections merging this

spirosoik commented 2 years ago

looks good to me