search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 147 forks source link

Add DNSConfig customization ability to RTCD service chart #353

Closed stafot closed 2 years ago

stafot commented 2 years ago

Issue: CLD-3730 Signed-off-by: Stavros Foteinopoulos stafot@gmail.com

Summary

Add DNSConfig customization ability to RTCD service chart

Ticket Link

https://mattermost.atlassian.net/browse/CLD-3730

streamer45 commented 2 years ago

Not sure what's the impact of this but to share some context, from the plugin side we currently run a resolution on the rtcd host every 10 seconds to check if new hosts came up/went down in order to support horizontal scaling.

stafot commented 2 years ago

@streamer45 Yeap, this lookup every 10 seconds with the default ndots configuration which defaults to 5 on kubernetes, creates 10 queries while it should need only 2 if we have the optimized setting for ndots which is 1. To be able to parameterize this configuration we need the field this PR adds. I can provide more details if you are interested.

phoinixgrr commented 2 years ago

🎖️ Works fine. Great work 👍

Non blocking recommendation following up: If we are interested in automatically generating README file, documenting the chart values, their defaults, and an optional description parsed from comments, worth taking a looking at https://github.com/norwoodj/helm-docs

Low hanging fruit 🥝 🍌 🍒

stafot commented 2 years ago

@phoinixgrr Totally agree, let's create a ticket for this I am more than happy to work on this.