rtcd: how to provide RTCD_RTC_ICESERVERS environment variable?

[MoeRT09]

Hey, there seems to be no way to get the RTCD_RTC_ICESERVERS environment variable to be applied when provided via a values.yaml file.

Here are examples I tried:

• daemonset:
  environmentVariables:
    RTCD_RTC_ICESERVERS: "[{\"urls\":[\"stun:stun.global.calls.mattermost.com:3478\"]}]"

  daemonset:
  environmentVariables:
    RTCD_RTC_ICESERVERS: '[{"urls":["stun:stun.global.calls.mattermost.com:3478"]}]'

  daemonset:
  environmentVariables:
    RTCD_RTC_ICESERVERS: >
          [
            {
            "urls":
              [
                "stun:stun.global.calls.mattermost.com:3478"
              ]
            }
          ]

  Results in Helm error:

  Error: UPGRADE FAILED: error validating "": error validating data: 
  ValidationError(DaemonSet.spec.template.spec.containers[0].env[0].value): invalid type for io.k8s.api.core.v1.EnvVar.value: got "array", 
  expected "string"

• daemonset:
  environmentVariables:
    RTCD_RTC_ICESERVERS: "\"[{\"urls\":[\"stun:stun.global.calls.mattermost.com:3478\"]}]\""

  Results in Helm error:

  Error: UPGRADE FAILED: YAML parse error on mattermost-rtcd/templates/daemonset.yaml: error converting YAML to JSON: yaml: line 44: did not find expected key

I assume, in https://github.com/mattermost/rtcd/commit/a366a489a001bf02a4066bc3d92b0507c772290d, the format that you supposed to provide here changed from comma separated list of string to JSON. But this change was not reflected in the Helm chart, as there is currently no way to provide JSON via values without Helm trying to parse it somehow.

[streamer45]

@MoeRT09

I believe it should be:

RTCD_RTC_ICESERVERS: "\'[{\"urls\":[\"stun:stun.global.calls.mattermost.com:3478\"]}]\'"

I know it's super ugly but it really helps to keep the inner value as valid JSON. Maybe we can find a better way in the future.

/cc @angeloskyratzakos