search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
162 stars 145 forks source link

Enables saml setting to be overridden #383

Open KhizerJaan opened 1 year ago

KhizerJaan commented 1 year ago

Summary

Previously , saml settings were not configured to be overridden , it would enable saml settings to be overridden.

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/382

mattermod commented 1 year ago

Hello @KhizerJaan,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

KhizerJaan commented 1 year ago

/check-cla

mattermod commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

erezo9 commented 1 year ago

@KhizerJaan the config.tpl doesnt apply to the deployment unless you add the config into a volumemount and volume since its a Kubernetes installation, the configuration is stored in the database and the whole point of the config file is irrelavent

if you see in the code you can see the config map is only applied to the load test and not the application it self hope this helps