search

mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
162 stars 145 forks source link

add customization for rtcd deployment #385

Closed erezo9 closed 1 year ago

erezo9 commented 1 year ago

This PR should add customization to the deployment to allow the user to choose between deployment and daemonset also adds the possibilty to use nodeport instead of cluster ip also removes the use of ingress since udp data cant go through layer 7 ingress

mattermod commented 1 year ago

Hello @erezo9,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

stylianosrigas commented 1 year ago

@erezo9 This PR can be closed, as this feature is already supported in chart version 1.2.1

erezo9 commented 1 year ago

@stylianosrigas ye but you didn’t add an option to customize hostport if needed Or the service it self I won’t use the helm chart because it not suitable for the on-prem environment I’ll close it because it didn’t get any respond in the past six months