Closed pablo-suazo closed 1 year ago
Hello @pablo-suazo,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla
and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
/check-cla
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@pablo-suazo thanks for the contribution. is it possible to fix the conflict?
@spirosoik Done
@pablo-suazo let's fix the lint too which seems it's failing now
@spirosoik Bumped the chart version
@pablo-suazo if you run make test
locally what's the output?
@spirosoik I don't have the code in local anymore
It seems it is not getting the helm manager chart from the helm repo, could you trigger the CI again?
yeah I did again, I will try to check this again
@spirosoik Same error
@spirosoik Same error in the test, can we try again?
@pablo-suazo I am on it there is an issue with dependencies and testing. I am checking it.
/update-branch
/update-branch
@spirosoik I think it is OK now, could you merge it in the master branch or in the next release?
@pablo-suazo could you bump the chart version as we did another merge please?
@spirosoik Done
@pablo-suazo there is a conflict, let's fix this and merge it.
@spirosoik I have fixed it
Summary
Adds ingressClassName support to mattermost-team chart Ticket Link
Fixes issue https://github.com/mattermost/mattermost-helm/issues/288