Closed mustdiechik closed 12 months ago
Hello @mustdiechik,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla
and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
/check-cla
@mustdiechik In my view these values (failureThreshold
,periodSeconds
,initialDelaySeconds
,timeoutSeconds
) shouldn't be hardcoded in the template. You could follow the approach we have on this PR.
/check-cla
+1 on what @stafot mentioned
@mustdiechik looks good. Did you sign the CLA? Seems that there's still an issue
/check-cla
@mustdiechik CLA looks good to me unsure why it fails. Although you need to resolve conflicts on this PR
@stafot check please
@spirosoik ^^
@mustdiechik let's have a similar PR for the enterprise edition too. It will be valuable there too.
Added startupProbe