search

mattermost / mattermost-load-test

[DEPRECATED] replaced by https://github.com/mattermost/mattermost-load-test-ng
Apache License 2.0
58 stars 43 forks source link

MM-16675 added AdminUsername config option to override 'ltadmin' #157

Closed reflog closed 5 years ago

reflog commented 5 years ago

Fixes: https://mattermost.atlassian.net/browse/MM-16675

crspeller commented 5 years ago

Why?

reflog commented 5 years ago

Why?

@crspeller I forgot to include the link to the JIRA ticket: https://mattermost.atlassian.net/browse/MM-16675 From the description:

The loadtest agent purports to support customizing the admin user by allowing a configuration for AdminEmail and AdminPassword, but it hard-codes a username of ltadmin. If the loadtest agent isn't responsible for creating the admin user – say because it already exists – and the username diverges, the loadtest will fail during authentication.

crspeller commented 5 years ago

@reflog But there aren't any auth changes here. The only change is when the user is created it would use that username. The auth only uses the email: https://github.com/mattermost/mattermost-load-test/pull/157/files#diff-d5fc29479b66151bc80efcecfc04d8b2R89 Which is why it wasn't configurable before.