Add Standup Raven to Marketplace

[ghost]

Summary

It's a team standup plugin. Can be used for daily standup, weekly standup or for any frequency.

Quick demo-

Review commit

https://github.com/standup-raven/standup-raven

Checklist

Product requirements

• [x] The plugin is published under an Apache v2 compatible license (e.g. no GPL, APGL). A list of compatible licenses can be found here.
• [x] The source code is available in a public git repository.
• [x] There is a public issue or bug tracker for the plugin, which is linked in the plugin documentation and linked via support_url in the manifest.
• [x] The plugin provides detailed usage documentation with at least one screenshot of the plugin in action, list of features, and a development guide. This is typically a README file or a landing page on the web. The link to the documentation is set as homepage_url in the manifest. A great example is the README of the GitHub plugin.
• [ ] For the current release and upcoming ones a changelog has to be published, with a link recorded in the release_notes_url property of the plugin.json manifest.
• [x] The plugin has to be out of Beta and be released with at least v1.0.0.
• [x] All configuration is accessible via the Mattermost UI.
• [x] The plugin ID defined in the manifest must not collide with the ID of an existing plugin in the Marketplace. It should follow the documentation's suggested naming convention.

Technical requirements

• [ ] The plugin works for 60k concurrent connections and in a high-availability deployment. Note: There are currently no publicly-available tools to verify these properties. As such, they are checked during code review by a developer.
• [x] The plugin logs important events on appropriate log levels to allow System Admins to troubleshoot issues.

Security requirements

• [ ] Security reviews do not reveal any exploitable vulnerabilities in the plugin.
• [x] The plugin provides an email address or a username on the Community Server used to report vulnerabilities in the future. Please post it into this issue or send it to ben.schumacher@mattermost.com.

Functional requirements

• [x] The plugin must set a min_server_version in the manifest.
• [ ] The plugin must work on all Mattermost versions greater than or equal to the min_server_version.

[ghost]

I'm actively working on fulfiling the remaining requirements.

[hanzei]

Awesome, thanks for submitting Standup Raven :+1:

It seems like a release_notes_url is missing , but that can be easily added in the review process.

I'm yet to confirm that the plugin doesn't cause issues in an HA environment. I will check that while doing a full code review.

The plugin uses a custom Makefile and not the default one from the Starter Template, which is fine. Heads up that I might have to do some adjustments to align the Makefile with the build system used for the Marketplace.

[hanzei]

The checklist below will be used to track the process of getting your plugin to the Marketplace. It's sole purpose it visibility.

Process checklist

• [x] Create a private fork under the Mattermost organization; master should only contain a README.md.
• [x] Give submitter read access to the fork.
• [x] Create PR to merge upstream into master.
• [ ] Request reviews.
• [ ] Cut plugin release.
• [ ] Add release to Marketplace.
• [ ] Reach out on Marketing Channel to tweet about the plugin.
• [ ] Work with @hanna.park regarding swag.

[ghost]

@hanzei I have to add HA compatibility by using this where I run the standup loop.

[hanzei]

Using the cluster package is definitely a good idea :+1:

Are there any potential issue with running the migrations process on multiple plugin instances?

[ghost]

@hanzei ah! That's a good point. It can cause issue if multiple nodes in the cluster start applying the same migration. What do other plugins in such case?

[hanzei]

The cluster package exposes a Mutex, which can guard against concurrent executions. Beside that tool you also either ensure the migration is idempotent or store in the db that the migration as already happened.

[ghost]

@hanzei Thanks! WIll try that out.

[ghost]

@hanzei I'm added to the private fork now. What's the next step for me on that fork?

Also, I'm working on the CircleCI plugin for the plugin bounty so please expect some delay on this. I'll try my best to not block the process.

[hanzei]

@harshilsharma63 I'm requested a review from @larkox on the code base. He will provide some early feedback. The next step for you is to implement the changes required for HA and respond to the upcoming feedback.

[ghost]

@hanzei thanks a ton! @larkox let me know if you have any questions on any part of the code. Also please feel free to add any scope of improvement or issue you see in the code as you traverse it.

@hanzei yes, I need to use the cluster job package and mutex package for migrations.

[hanzei]

Closing this for now as https://github.com/standup-raven/standup-raven seems to be abandoned. @harshilsharma2 Please let me know if you or other want to pick with up again.