Closed ghost closed 2 years ago
I'm actively working on fulfiling the remaining requirements.
Awesome, thanks for submitting Standup Raven :+1:
It seems like a release_notes_url
is missing , but that can be easily added in the review process.
I'm yet to confirm that the plugin doesn't cause issues in an HA environment. I will check that while doing a full code review.
The plugin uses a custom Makefile
and not the default one from the Starter Template, which is fine. Heads up that I might have to do some adjustments to align the Makefile
with the build system used for the Marketplace.
The checklist below will be used to track the process of getting your plugin to the Marketplace. It's sole purpose it visibility.
master
should only contain a README.md
.master
.@hanna.park
regarding swag.@hanzei I have to add HA compatibility by using this where I run the standup loop.
Using the cluster
package is definitely a good idea :+1:
Are there any potential issue with running the migrations process on multiple plugin instances?
@hanzei ah! That's a good point. It can cause issue if multiple nodes in the cluster start applying the same migration. What do other plugins in such case?
The cluster
package exposes a Mutex
, which can guard against concurrent executions. Beside that tool you also either ensure the migration is idempotent or store in the db that the migration as already happened.
@hanzei Thanks! WIll try that out.
@hanzei I'm added to the private fork now. What's the next step for me on that fork?
Also, I'm working on the CircleCI plugin for the plugin bounty so please expect some delay on this. I'll try my best to not block the process.
@harshilsharma63 I'm requested a review from @larkox on the code base. He will provide some early feedback. The next step for you is to implement the changes required for HA and respond to the upcoming feedback.
@hanzei thanks a ton! @larkox let me know if you have any questions on any part of the code. Also please feel free to add any scope of improvement or issue you see in the code as you traverse it.
@hanzei yes, I need to use the cluster job package and mutex package for migrations.
Closing this for now as https://github.com/standup-raven/standup-raven seems to be abandoned. @harshilsharma2 Please let me know if you or other want to pick with up again.
Summary
It's a team standup plugin. Can be used for daily standup, weekly standup or for any frequency.
Quick demo-
Review commit
https://github.com/standup-raven/standup-raven
Checklist
Product requirements
support_url
in the manifest.README
file or a landing page on the web. The link to the documentation is set ashomepage_url
in the manifest. A great example is theREADME
of the GitHub plugin.release_notes_url
property of theplugin.json
manifest.Technical requirements
Security requirements
Functional requirements
min_server_version
in the manifest.min_server_version
.