search

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.25k stars 1.36k forks source link

Markdown Code syntax highlighting does not work #4056

Closed euschn closed 1 year ago

euschn commented 4 years ago

Summary

Syntax highlighting in Markdown code blocks does not work.

Environment Information

Steps to reproduce

  1. Post a message with a syntax highlighted code snippet, e.g.: 
    public static void main(String[] args) {
int x = 5;
System.out.print.ln("hi");
}
  2. Observe that in the browser client, the code is properly highlighted/colored
  3. Observe that in the mobile client, there is no syntax highlighting

Expected behavior

The code block should have syntax highlighting.

enahum commented 4 years ago

Last time I tried to add syntax highlight feature it was terribly slow, specially on Android, so for now it won’t be added

euschn commented 4 years ago

Too bad. Any insights on why it was slow?

dbogatov commented 4 years ago

Slack seems to support it. So it is possible to do in a right way (i.e. without performance degrade).

enahum commented 4 years ago

@dbogatov slack uses a totally different technology and approach. Can you think of alternatives on how to do this?

karantin2020 commented 2 years ago

Hello. Is there any way to add syntax highlight to mobile version? It is very useful. May be need help?

enahum commented 2 years ago

@karantin2020 help is always appreciated :)

larkox commented 1 year ago

Closing as this should be already solved on V2.