mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.25k stars 1.36k forks source link

Tap on notification from android in slow network, not opening respective channel/direct message. #4374

Closed sabbir360 closed 1 year ago

sabbir360 commented 4 years ago

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:

Summary

Tap on notification from android in slow network, not opening respective channel/direct message.

Environment Information

Steps to reproduce

How can we reproduce the issue? Stop mattermost application, or battery saver itself can do it sometimes, use 3G or lower speed internet. While you TAP new notification it will not open respective channel/direct message.

Expected behavior

Notification should open respective channel/direct message.

Observed behavior

I believe its happen while mattermost app opened and connection with server not happened immediately. Also, in a case, where you are on a different channel and notification happened on another channel.

Possible fixes

Should need some script/checking if current channel is not the channel notification came to, and open channel immediately its connected to server, if user interacted before channel operation done, should mark the channel as unread.

enahum commented 4 years ago

I’m afraid your suggestion in already happening here https://github.com/mattermost/mattermost-mobile/blob/master/app/actions/views/root.js#L67 and https://github.com/mattermost/mattermost-mobile/blob/master/app/actions/views/root.js#L118.

Does it happen when the notification belongs to a channel in a different team or the same team?

sabbir360 commented 4 years ago

Its happening for same team as well. Ok, looks like it's patched? I will observe more and get back.

ghost commented 4 years ago

I had a user report this exact issue today.

Environment Information

sabbir360 commented 4 years ago

I am also found this happened again for my version.

Environment Information

larkox commented 1 year ago

Closing due to the age of the ticket and that it should be already solved in V2.