Closed cguess closed 1 year ago
@grundleborg do you know if this is the WS on the server or is it just that the client does not seem to support it ?
For what it's worth, the websockets connect from the browser just fine (including verified in the developer tools).
@enahum since the TLS is being terminated at Nginx in this example, I don't think the server has anything to do with it. Also see @cguess comment above mine.
Thanks @grundleborg
@cguess thanks for letting us know, I’ll incestigate, in case is needed we are going to have to report this to the react native team.
Would yo be interested in drafting and submitting a PR to update the docs to clarify that TLS 1.3 does not work with the mobile app websocket?
Will do.
-Christopher Guess cguess@gmail.com US/WhatsApp/Signal: +1 262.893.1037 PGP: AAE7 5171 0D82 B45B
On Mon, Jul 13, 2020 at 8:55 AM Elias Nahum notifications@github.com wrote:
Thanks @grundleborg https://github.com/grundleborg
@cguess https://github.com/cguess thanks for letting us know, I’ll incestigate, in case is needed we are going to have to report this to the react native team.
Would yo be interested in drafting and submitting a PR to update the docs to clarify that TLS 1.3 does not work with the mobile app websocket?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mattermost/mattermost-mobile/issues/4557#issuecomment-657543398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOYQXHWNDPYUSGSDCPXHTR3L73LANCNFSM4OW3CYHA .
Hey, can we fix this? why can we not use TLSv1.3 on only SOME platforms and still get marginal functionality. At this point, TLSv1.3 is a critical feature for security, particularly since it removes many old ciphers that could be a large security hole in misconfigured servers (among which there are certainly many). TLSv1.3 also improves speed dramatically with its shorter handshake, which is required for you to compete with larger services which "just work" and are "seamless", or even "magic". I dont understand how this could even happen programmatically but it sorely disappoints me. Opening my server to less secure and higher cost non-elliptic curve cryptography is honestly testing my loyalty to mattermost, and is honestly just sad.
@DSchalla can you help verify this? Also check this thread I found, could it be related? https://developer.apple.com/forums/thread/132286
Based on the code in RN implementation, it looks like the right values are being set https://github.com/facebook/react-native/blob/master/Libraries/WebSocket/RCTSRWebSocket.m#L506
Jira ticket for this issue: DOPS-175: MM server with TLS 1.3 (To Do)
I guess since this ticket is still open, this is still an issue today?
I've had TLSMinVer
set to 1.3
for a long time, and no one ever complained. But the other day I changed my Let's Encrypt certs from RSA to ECDSA and since then coworkers using the iOS/Android app cannot connect, but using any browser from any OS works fine.
Is what I'm seeing the same as this ticket?
Can someone please add this to documentation? I've spent two days fighting this and when i've added TLSv1.2 to nginx(where TLSv1.3 only) it worked like a charm No more annoying bar that says connecting, finally
@kz159 Do you have an idea on where in the documentation you'd expect to find this information? Would you be open to creating a docs issue for this here https://github.com/mattermost/docs/issues (I can also help create an issue if you'd prefer)?
The upcoming mobile v2 should support TLS1.2 and TLS 1.3 for websocket connections
@amyblais sure! and i would love to take some help with this, how we will deal with this?
@amyblais here, can you review? https://github.com/mattermost/docs/issues/6070
Looks good, thank you!
Happy to help! Thank you for mattermost!
Closing since this is solved for V2.
Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
Issue in one concise sentence. Documentation should note that when the iOS app attempts to create a websocket connection with a server only supporting TLS 1.3, it will never succeed.
Environment Information
Steps to reproduce
Expected behavior
It'd make sense to ensure that the app supports the strongest and most up to date TLS versions
Observed behavior
SSLHandshake fails (according to system logs on device)
Possible fixes
At least add this to the documentation either in this repo or in the server documentation