mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.2k stars 1.33k forks source link

Archived Channels reappears on v1.47.1 (Build 375) #5777

Closed acataluddi closed 1 year ago

acataluddi commented 2 years ago

Summary

After having upgraded Mattermost, channels archived long time ago are showing again. Such channels are only showing on mobile and not visible on the desktop/web application, as expected. By clicking on it, the mobile client confirms that the channel is an archived one (see screenshot below):

Archive-Bug

Environment Information

Steps to reproduce

  1. Archive a channel on Mattermost (desktopor web).
  2. Open the Mattermost mobile client
  3. Notice the archived channel showing,

Expected behavior

Having the archived channel hidden.

Observed behavior (that appears unintentional)

//

Possible fixes

//

esethna commented 2 years ago

Thanks for the report!

@amyblais @shazm can we open a ticket for this and queue for dot release if this is reproing?

amyblais commented 2 years ago

cc @josephbaylon I haven't personally been able to reproduce.

esethna commented 2 years ago

@acataluddi I attempted your repro steps but was not able to reproduce. Can you help provide more detailed steps if your reproduction is consistent?

josephbaylon commented 2 years ago

@amyblais I'm also unable to reproduce with the given steps.

acataluddi commented 2 years ago

Hi @amyblais,

Just in case this can explain your inability to reproduce, the channels have been archived before the iOS app ugrade and the server upgrade from 5.x to 6.0.0.

Thanks, Adriano C.

shaz-r commented 2 years ago

Hey @acataluddi, could you give us the exact version numbers (or build numbers) of the server and the mobile app before the upgrade? I setup a 5.x instance, and then upgraded it to a 6.x instance but the mobile app doesn't show any archived channels. Could you also confirm if you have/had legacySidebar enabled? I'm wondering if they're popping up in the new categories view or the previous sidebar.

esethna commented 2 years ago

@shazm FYI legacy sidebar should be removed in v6.0 (from server/webapp) with all of the config deprecations we did

acataluddi commented 2 years ago

Hey @acataluddi, could you give us the exact version numbers (or build numbers) of the server and the mobile app before the upgrade?

Hi @shazm,

The previous server version was 5.34.0 (sorry, I don't have the build as we don't track it in our internal documentation). Instead, I cannot say what was exactly the previous mobile version but my gut feeling says this might not be relevant.

Could you also confirm if you have/had legacySidebar enabled?

If the legacySidebar is the old one, not allowing the channels grouping, etc. then no, it wasn't as we started using (and enjoying) the new sidebar immediately.

Thanks,
Adriano

acataluddi commented 2 years ago

Hi @shazm,

I've just realised we have a backup of the previous installation and I could extract the manifest.txt file accordint to that it seems the actual release server was 5.34.0 (Build 2046). Here is the complete manifest file content:

BUILD_EE=557ca60b5b340e3374e844e65bd82fdef62c1280_2c294523d63cb5947ffa657f2696433772ee9746
CREATION_DATE=2021-04-16T18-10-06.740419906
DOCKER_TAG=2742_557ca60b_2c294523_68476db7
EDITION=ee
MM_PACKAGE=https://s3.amazonaws.com/releases.mattermost.com/gitlab/bundle/ee/onprem/2742_557ca60b_2c294523_68476db7/mattermost-enterprise-linux-amd64.tar.gz
PIPELINE_IID_BUILD_EE=2046
PIPELINE_IID_BUNDLE=2742
REF_BUILD_EE=release-5.34
REF_BUNDLE=release-5.34
REF_ENTERPRISE=release-5.34
REF_MATTERMOST_SERVER=release-5.34
REF_MATTERMOST_WEBAPP=release-5.34
SHA_BUILD_EE=5deef43e08fabd455725c6477a22f97fdfc51c49
SHA_BUNDLE=05971c710923caf2068e5d85ad177a2a4bfb5faf
SHA_ENTERPRISE=2c294523d63cb5947ffa657f2696433772ee9746
SHA_MATTERMOST_SERVER=557ca60b5b340e3374e844e65bd82fdef62c1280
SHA_MATTERMOST_WEBAPP=68476db78ec63fd6d99b55d34894a644eef4e725
TRIGGERED_BY=mattermost-server
TRIGGER_PIPELINE_IID=3022
TYPE=onprem

Thanks, Adriano C.

shaz-r commented 2 years ago

Hi @shazm,

I've just realised we have a backup of the previous installation and I could extract the manifest.txt file accordint to that it seems the actual release server was 5.34.0 (Build 2046). Here is the complete manifest file content:

BUILD_EE=557ca60b5b340e3374e844e65bd82fdef62c1280_2c294523d63cb5947ffa657f2696433772ee9746
CREATION_DATE=2021-04-16T18-10-06.740419906
DOCKER_TAG=2742_557ca60b_2c294523_68476db7
EDITION=ee
MM_PACKAGE=https://s3.amazonaws.com/releases.mattermost.com/gitlab/bundle/ee/onprem/2742_557ca60b_2c294523_68476db7/mattermost-enterprise-linux-amd64.tar.gz
PIPELINE_IID_BUILD_EE=2046
PIPELINE_IID_BUNDLE=2742
REF_BUILD_EE=release-5.34
REF_BUNDLE=release-5.34
REF_ENTERPRISE=release-5.34
REF_MATTERMOST_SERVER=release-5.34
REF_MATTERMOST_WEBAPP=release-5.34
SHA_BUILD_EE=5deef43e08fabd455725c6477a22f97fdfc51c49
SHA_BUNDLE=05971c710923caf2068e5d85ad177a2a4bfb5faf
SHA_ENTERPRISE=2c294523d63cb5947ffa657f2696433772ee9746
SHA_MATTERMOST_SERVER=557ca60b5b340e3374e844e65bd82fdef62c1280
SHA_MATTERMOST_WEBAPP=68476db78ec63fd6d99b55d34894a644eef4e725
TRIGGERED_BY=mattermost-server
TRIGGER_PIPELINE_IID=3022
TYPE=onprem

Thanks, Adriano C.

Awesome thanks for this - I'll try again today to reproduce this.

larkox commented 1 year ago

There has been many changes about this in the last year, and I guess this should be solved in V2. @acataluddi if you are still seeing this issue with the latest beta (V2), feel free to reopen the ticket.

acataluddi commented 1 year ago

Thank you @larkox, great support!