search

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.25k stars 1.37k forks source link

login: Phabricator support #6597

Closed okias closed 1 year ago

okias commented 2 years ago

Summary

Support login though Phabricator.

Possible fixes

MR will follow.

mkraft commented 2 years ago

@okias Can you please elaborate on your request to add Phabricator as an authn method? We haven't seen any other requests for this in our ProductBoard feature request tracking system. Also it looks like the product is no longer maintained.

glunardi commented 2 years ago

Thanks a lot @mkraft for your reply. Working together with @okias (and @wget) here where we still use Phabricator quite extensively. Currently we are carrying these changes downstream and like with all of these, we would really appreciate it if we could not have to. It has been holding us back from releases more often to our internal users.

We are big fans and users of Mattermost (all internal communication done with it). It would be amazing if you could help us by ease releasing the mattermost-mobile app to our users more often.

Or even better, with this we could probably adopt your upstream delivered APK from the stores.

We would be willing to help monitor these changes upstream if they were to be affected by codebase updates.

larkox commented 1 year ago

@laneycs @mkraft Has there been any decision regarding this?

mkraft commented 1 year ago

@glunardi If you'd be willing to adapt your previous PR to the new mobile v2 codebase and help us with testing, I think we could work together to get this into the core code so that you don't have to maintain this change yourself ongoing. How does that sound?

glunardi commented 1 year ago

@glunardi If you'd be willing to adapt your previous PR to the new mobile v2 codebase and help us with testing, I think we could work together to get this into the core code so that you don't have to maintain this change yourself ongoing. How does that sound?

Thanks for the reply @mkraft! I will talk to @okias right away and see how we can get this done quickly.

okias commented 1 year ago

@mkraft Hello! I adapted the patch and currently using the apk built from CI. Also, colleagues tested, and these changes worked for them well.

m1lt0n commented 1 year ago

Hello @okias @glunardi

First of all, I'd like to thank you for the time you've invested in adding support for Phabricator in the mobile app and adapting your PR for mobile v2.

After some further internal discussions and given that Phabricator is not maintained and that we don't have more requests for supporting it, unfortunately at this point, we will not move forward with merging the relevant PR and maintaining the functionality on our side.

Sorry for the inconvenience. In case something changes in the future, we will keep you in the loop.