[IMPR] improvement of log out

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native

https://about.mattermost.com/

Apache License 2.0

2.25k stars 1.36k forks source link

[IMPR] improvement of log out #7076

Open civodul999 opened 1 year ago

civodul999 commented 1 year ago

Summary

when we log out of the mobile application, we need to specify again server's url and display name.

Environment Information

Device Name: android phone
OS Version: version 11
Mattermost App Version: 2.0.0 build 45203
Mattermost Server Version: version 5.2.2 commit 2030c66

Steps to reproduce

on mobile phone (android), with the application :

log in to your server
then log out and confirm

Expected behavior

All data will be removed

Observed behavior (that appears unintentional)

no errors, all datas are deleted

Possible fixes

when we log out, it will be nice if we can log in again just by typing the password. Each time, we have to type url, display name, login and password.

maybe an option to log out and keep the datas except the password
another option to erase all datas

enahum commented 1 year ago

We have this ticket opened https://mattermost.atlassian.net/browse/MM-41961 if you want to contribute :)

Sudhanva-Nadiger commented 1 year ago

Should we use local storage to store these information?

larkox commented 1 year ago

@Sudhanva-Nadiger The local storage should have already that information if you only log out, instead of removing the server. We would only need to show that information to the user.

enahum commented 1 year ago

I can open this ticket https://mattermost.atlassian.net/browse/MM-41961 as help wanted if someone is interested

Sudhanva-Nadiger commented 1 year ago

I want to try this !

Sudhanva-Nadiger commented 1 year ago

Hi @larkox ! Correct me if I am wrong ! I was reading the code around the logout process! in that its not doing anything with local database. So all the data will still be there in the local database and we need to show it when user is again trying to log in again !

larkox commented 1 year ago

So... the "server database" is removed, but the server information (url and name, and not much more) will still be in the "app database". So the idea here is something like:

If there is no server information in the app database, show the normal "add a server" screen
If there is information in the app database, show the list of servers as shown in the ticket https://mattermost.atlassian.net/browse/MM-41961

Does this make sense?

Sudhanva-Nadiger commented 1 year ago

Yesss ! Thanks

be-glass commented 6 months ago

Thanks @amyblais for correctly identifying #7939 as a duplicate!

Please note that this is about an enhancement to fix a usability issue, rather than a request for a new feature. This current behavior of the mobile client prevents a significant fraction of inexperienced users from using Mattermost.