search

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.25k stars 1.37k forks source link

Editing of messages not working (on Android?) #7254

Closed q-wertz closed 1 year ago

q-wertz commented 1 year ago

Per Mattermost guidelines, GitHub issues are for bug reports: http://www.mattermost.org/filing-issues/.

For troubleshooting see: http://forum.mattermost.org/. For feature proposals see: http://www.mattermost.org/feature-requests/

If you've found a bug--something appears unintentional--please follow these steps:

  1. Confirm you’re filing a new issue. Search existing tickets in Jira to ensure that the ticket does not already exist.
  2. Confirm your issue does not involve security. Otherwise, please see our Responsible Disclosure Policy.
  3. File a new issue using the format below. Mattermost will confirm steps to reproduce and file in Jira, or ask for more details if there is trouble reproducing it. If there's already an existing bug in Jira, it will be linked back to the GitHub issue so you can track when it gets fixed.

Summary

Cannot confirm/accept after editing a message.

Environment Information

Steps to reproduce

  1. Write a message
  2. Long tap message and select "Edit"
  3. Change the message

Expected behavior

The is an accept or checkmark button to accept the changes and one returns to the channel view.

Observed behavior (that appears unintentional)

No possibility to accept. Also the "Aport" symbol in the upper left corner does not work. I have to kill the app to return to anything else than the edit message view.

This might be an android/device specific issue. Colleague (with iOS) can accept the changes in the upper right corner.

Screenshot_20230331-104635

Possible fixes

If you can, link to the line of code that might be responsible for the problem

q-wertz commented 1 year ago

Tried again, works now :man_shrugging: Sorry for the noise.

Might be related to the overall "lagginess" of the app since v2 :thinking: (having lot's of performance issues and takes sometimes lot's of time (range of 10 seconds) until the app reacts) as for example reported in https://github.com/mattermost/mattermost-mobile/issues/7202

Ch1llb0 commented 1 year ago

I would recommend reopening this issue... It happens here very, very often. When I give the app a fresh start, editing works a few times, but then, especially when re-editing a message, it simply doesn't show the save button. On Android 13 here, BTW.

larkox commented 1 year ago

I just was able to reproduce it. Will take a look.

q-wertz commented 1 year ago

I just tested it again.

What looks strange to me is, that after opening the edit window, there is nothing in the upper right corner. Then when starting to do changes the Save button appears. From now on, when the text is the same as the original, the Save is greyed out.

Why is there a difference between opening (no changes yet) and no changes later? Maybe in the implementation of this functionality there are some issues…

The issue I described at the beginning didn't appear to me again…

larkox commented 1 year ago

@Ch1llb0 Can you verify that is also the behaviour you are seeing (editing makes the button appear)? That is what I can reproduce on my side, and have a theory, but does not reproduce consistently across all my devices.

Ch1llb0 commented 1 year ago

Editing doesn't always make the button appear. Sometimes it does, it sometimes even when I wait for some time after editing chars or whole words, the button doesn't appear and the abort functionality doesn't respond either.