mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.23k stars 1.35k forks source link

Mattermost for android - HEIC Image from gallery does not auto convert to jpg and just uploads a HEIC file. #7546

Closed ageekhere closed 1 month ago

ageekhere commented 1 year ago

Per Mattermost guidelines, GitHub issues are for bug reports: http://www.mattermost.org/filing-issues/.

Summary

Mattermost for android - HEIC Image from gallery does not auto convert to jpg and just uploads a HEIC file.

Environment Information

Steps to reproduce

How can we reproduce the issue (what version are you using?) First make sure high efficiency pictures is enabled in the camera settings and using Mattermost for android from the play store (2.7.0) and Mattermost Version: 7.10.4 take a picture on the android device and use the upload an image icon and select a HEIC picture.

Expected behavior

The image should show within the chat

Observed behavior (that appears unintentional)

The HEIC picture is uploaded as a file

Screenshot 2023-09-16 173403

Other notes

The current work around is to take a picture from Mattermost using the camara icon, this creates an image that can show up in the chat.

amyblais commented 1 year ago

@lindy65 Are you able to reproduce this on Android?

lindy65 commented 1 year ago

Hi @amyblais

I am not able to reproduce this issue. HEIF images (my Android's high efficiency image format) upload fine for me in Mattermost.

My android is slightly different though and the setting is "High Efficiency Image Format". Images are saved as HEIF

I did try downloading a sample HEIC but it won't display on my android and if I attach it to a post it attaches a broken image. Not sure whether this is because my Android uses HEIF and not HEIC.

Perhaps @ageekhere can update to v2.8 of the mobile app and try again? Perhaps also the latest version of Mattermost?

ageekhere commented 1 year ago

I updated to mattermost android to app v2.8 and mattermost server to Mattermost Version: 8.0.1 (I use gitlab) The issue is still there, the HEIC file uploads as an attachment for android.

lindy65 commented 1 year ago

Thanks for the feedback @ageekhere

@amyblais - perhaps someone with an Android that uses HEIC format (maybe a similar device to the reporter - Galaxy A73 5G) can try to reproduce?

enahum commented 1 year ago

No need to reproduce, this is in fact 100% true, we never made any improvements on HEIC, server does not modify the file nor the Android client, iOS is able to render heic files natively

amyblais commented 1 year ago

Opened https://mattermost.atlassian.net/browse/MM-54521.

amyblais commented 1 month ago

Closing as there is a Help Wanted issue open for this https://github.com/mattermost/mattermost/issues/25241.