mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.2k stars 1.33k forks source link

Automatic update to version 2.8.1 breaks the application work for iPhone 5s #7581

Closed Zeratyl06 closed 11 months ago

Zeratyl06 commented 11 months ago

Summary

On iPhone 5s, install the update to 2.8.1. Application won't start.

Environment Information

Possible fixes

Publish version 2.8.0 for iPhone 5s (12.5.7) in the Apple Store and limit compatibility to this version.

amyblais commented 11 months ago

@enahum Was this an intentional change? I've opened https://mattermost.atlassian.net/browse/MM-54726.

enahum commented 11 months ago

The minimum OS version is 13.4 and the report mentions 12.5.7

amyblais commented 11 months ago

Ah, yes. @Zeratyl06 the minimum supported iOS version is now v13.4 https://github.com/mattermost/mattermost-mobile#mattermost-mobile-v2.

Zeratyl06 commented 11 months ago

I saw the changelog, the problem is that the App Store says version 2.8.1 is compatible with iphone 5s (maximum available ios version is 12.5.7) and installs version 2.8.1 (which requires ios version 13.4). After installing version 2.8.1 on iPhone 5s, it is not possible to roll back to version 2.8.0; the application becomes inoperable.

amyblais commented 11 months ago

Ah, I didn't realize that the iPhone version is also affected. I'll update docs.

Zeratyl06 commented 11 months ago

Will it be possible to install version 2.8.0 via the App Store on iPhone 5s devices with iOS 12.5.7?

enahum commented 11 months ago

I'll check if I can patch it to work on iOS 12.4 and in that case we could release 2.8.2

But your better alternative is to subscribe to the beta builds with testflight and install 2.8.0 from there listed in the previous builds section

Zeratyl06 commented 11 months ago

I'll hope for version 2.8.2. Because not all company employees can connect to beta builds.

enahum commented 11 months ago

I've been unable to test it on an iPhone 5s as I do not own one but more importantly XCode does not have the Simulators available any more as it reached EOL.. going to try something (that could break my dev environment) to try and add the simulators from an old definition file that I found.

If this does not work, then we will have to come up with a different solution.

@amyblais we should fix 2.9 before releasing so that the minimum OS version is reflected in the App Store to avoid this from happening again

amyblais commented 11 months ago

we should fix 2.9 before releasing so that the minimum OS version is reflected in the App Store to avoid this from happening again

@enahum Are there action items for me, or are you referring to fixing https://mattermost.atlassian.net/browse/MM-54726 for v2.9?

enahum commented 11 months ago

@amyblais let's see if we keep the support to iOS 12.4, just need to make sure the app runs without issues but I cannot find a way to test it yet.. we could just cut a build, push it to testflight (external testers) and have someone with an iPhone 5s test out the beta build

enahum commented 11 months ago

@Zeratyl06 would you be willing to try out a Beta version that we can publish on TestFlight to see if it works ok? let me know as soon as you can so that I can proceed to publish it. You can enroll in TestFlight by clicking this link from your iOS device

Zeratyl06 commented 11 months ago

Unfortunately, I won't be able to test it. TestFlight is only available on iOS 14 and higher. image

Zeratyl06 commented 11 months ago

I can try installing a signed .IPA application file via iMazing. If possible.

enahum commented 11 months ago

I can try installing a signed .IPA application file via iMazing. If possible.

do you know if this is a regular app store signature ?

Zeratyl06 commented 11 months ago

Don't know. Probably yes, because I can save the current version of the application from the App Store to an .IPA file and install it later.

enahum commented 11 months ago

Try this ipa file

Zeratyl06 commented 11 months ago

Failed with error A valid provisioning profile for this executable was not found.

enahum commented 11 months ago

weird, as it was build the same way we distribute the app in the app store. So I guess there is no easy way for us to test it.. I have tested in newer OS versions an seems to be working fine, maybe we can risk it but not sure.. @amyblais thoughts?

amyblais commented 11 months ago

@enahum It sounds tricky, but since you feel mostly confident, then I have confidence too to move forward.

amyblais commented 11 months ago

Queued for v2.8.2 dot release,

Zeratyl06 commented 11 months ago

Thank you! Works!

enahum commented 11 months ago

Thank you! Works!

Awesome!