search

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.25k stars 1.36k forks source link

Visual Error with Samsung Multi Window View #7633

Closed PG-Fuury closed 12 months ago

PG-Fuury commented 1 year ago

The top of the Mattermost window's rendered elements gets an offset that, eyeballed, seems to be as far from the top of the window as the edge of the window from the edge of the screen. Without looking at the code it seems like the app is trying to prevent rendering culled elements by implementing a "blanking interval" at the top, but the window view renders everything into the window.

amyblais commented 1 year ago

Hi @PG-Fuury, what Mattermost mobile app version and Mattermost server version are you on? What Samsung version are you using? Can you help share a screenshot of what you're seeing?

PG-Fuury commented 1 year ago

Server: WeTalk 8.1.3 hosted by the CAU Kiel mattermost-mobile 2.9.0 as downloaded from Google Play Android 13 with OneUI 5.1 Screenshot_20231027_104254_Firefox

PG-Fuury commented 1 year ago

one thing to note is that the offset gained persists statically through window movement and even leaving windowed mode entirely

amyblais commented 1 year ago

Thank you, opened https://mattermost.atlassian.net/browse/MM-55179.

larkox commented 12 months ago

@PG-Fuury I have been trying to reproduce, but I have not been able. Any other notes on how I may be able to reproduce this?

PG-Fuury commented 12 months ago

my device is a Samsung A52s 5G, and the way I can consistently produce the issue is by either moving the app from fullscreen into windowed mode, which leads to a black bar the thickness of the Camera Cutout, or by opening it in windowed directly which creates a blanked area the distance from the top of the window to the top of the screen including the notification bar.

I actually also managed to activate this bug by setting Display>Camera Cutout>[mattermost-mobile]>"Hide Camera Cutout", which creates a CC-thick black bar at the top of the app area. In essence, the rendering assumes that its draw area starts at the top of the screen, polls where it should start drawing, then sets that absolute offset from the top, which is fine in regular fullscreen use, but when hiding the CC or in Popup view that assumption is incorrect.

larkox commented 12 months ago

@PG-Fuury I see it now. For some reason in my device the blanked area is smaller, but hopefully the same root cause.

I will create a help wanted ticket, so if it is something you would be willing to look into, let me know!

amyblais commented 12 months ago

A Help Wanted issue was opened here https://github.com/mattermost/mattermost/issues/25452