mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.24k stars 1.36k forks source link

Android app stops repeatedly from emoji-picker screen #8252

Open trystero11 opened 3 weeks ago

trystero11 commented 3 weeks ago

Summary

Android app stops on Pixel 9 Pro whenever I go to the emoji-picker screen

Environment information

Steps to reproduce

  1. Press the "happy-face/plus" icon underneath a message to get to the emoji-picker screen.
  2. Press the Search field and start typing a search term (e.g., thumbs). Mattermost stops. THIS IS THE BUG.

Expected behavior

I expect to be able to search for emoji without the app stopping. I can do this without issues on the macOS and Windows desktop clients.

Other

I didn't have this issue with the Android client on my previous phone (Google Pixel 5), and it doesn't occur in the macOS and Windows desktop clients, so it might be specific to the Pixel 9 Pro (or Pixel 9s in general).

Haliax commented 2 weeks ago

We had the same problem in our instance. We couldn't pin the problem to a specific server or client version. The app also crashed randomly in specific channels and threads.

But we figured out, that with disabled custom-emojis, the app no longer crashed. We tested every single custom-emoji and found one emoji that caused the crashes. The problem was displaying it. It did not matter whether it was displayed in the emoji-picker, in a message or as a reaction.

After disabling that specific emoji (and reloading the app with a sign-out and sign-in), the crashes stopped.

We have no idea about the reason. The emoji was part of our instance for multiple years and there were not problems with it. The emoji was a gif. But other gifs are working fine.

amyblais commented 2 weeks ago

Opened https://mattermost.atlassian.net/browse/MM-61196.

marianunez commented 2 weeks ago

We had the same problem in our instance. We couldn't pin the problem to a specific server or client version. The app also crashed randomly in specific channels and threads.

But we figured out, that with disabled custom-emojis, the app no longer crashed. We tested every single custom-emoji and found one emoji that caused the crashes. The problem was displaying it. It did not matter whether it was displayed in the emoji-picker, in a message or as a reaction.

After disabling that specific emoji (and reloading the app with a sign-out and sign-in), the crashes stopped.

We have no idea about the reason. The emoji was part of our instance for multiple years and there were not problems with it. The emoji was a gif. But other gifs are working fine.

@Haliax would it be possible to share the offending custom emoji?

marianunez commented 2 weeks ago
  • Mattermost Server Version: Not sure how to tell

@trystero11 you should be able to see your Mattermost Server version by going to Account Settings > Settings > About Mattermost in your mobile phone. Can you share the version?

octomike commented 2 weeks ago

We see the same over here and have isolated at least one emoji that triggers a reproducible crash. App data must be deleted completely to recover from this.

My os (graphene) creates a crash report with hardened_malloc and reports detected write after free. Paired with custom emojis, this sounds a little concerning. I can also provide a full crash report and emoji(-of-mobile-death), if you tell me where to send it.

trystero11 commented 1 week ago

My Mattermost Server version is 10.1.1 (Build 11162711545).

marianunez commented 1 week ago

We see the same over here and have isolated at least one emoji that triggers a reproducible crash. App data must be deleted completely to recover from this.

My os (graphene) creates a crash report with hardened_malloc and reports detected write after free. Paired with custom emojis, this sounds a little concerning. I can also provide a full crash report and emoji(-of-mobile-death), if you tell me where to send it.

@octomike can you send the crash report and the custom emoji to maria.nunez@mattermost.com? Thanks!