[MM-60236] Remove ephemeral posts on refresh/during initial load

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native

https://about.mattermost.com/

Apache License 2.0

2.26k stars 1.37k forks source link

[MM-60236] Remove ephemeral posts on refresh/during initial load #8260

Closed theoforger closed 3 weeks ago

theoforger commented 1 month ago

Summary

Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/28408 Jira Ticket: https://mattermost.atlassian.net/browse/MM-60236

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.
[ ] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Device: Android Emulator Version: Android 15
Device: Google Pixel 7 Version: Android 14

Release Note

Fixed an issue where ephemeral posts don't go away after a refresh or an app relaunch.

mattermost-build commented 1 month ago

Hello @theoforger,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

theoforger commented 1 month ago

I've just made the requested changes. Also realized that there's a constant PostTypes.EPHEMERAL I could use instead of the string 'system_ephemeral'. I changed that as well.

Let me know if there's anything else!

In the meantime I'll be working on indexing the type column 👍

rahimrahman commented 3 weeks ago

/update-branch

theoforger commented 3 weeks ago

@rahimrahman I just pushed some changes (requested here). Let me know if it's working as intended now 🙏

rahimrahman commented 3 weeks ago

@yasserfaraazkhan passing this to you for QA review. FYI: I have tested this myself, and it looks good.

UX wise, I would have loved to see some animation to slowly remove the row.

theoforger commented 3 weeks ago

@yasserfaraazkhan Thanks for the approval! 🙏

@rahimrahman Just in case you missed my message from the community server: I noticed the recent force push reversed my changes from the previous commit. Was that supposed to happen?

Edit: Sorry I just saw the comment above. Thanks for explaining 🙏