Mobile drafts - Githubissues

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native

https://about.mattermost.com/

Apache License 2.0

2.26k stars 1.37k forks source link

Mobile drafts #8280

Open Rajat-Dabade opened 1 month ago

Rajat-Dabade commented 1 month ago

Summary

Separate tab for Drafts in mobile.

Ticket Link

https://mattermost.atlassian.net/browse/MM-39356

Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.
[ ] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: iOS version 17.5 (Both on iPhone and ipad)

Screenshots

Release Note

Added a feature for having a separate tab for Drafts in mobile.

Note: Will cover all the test case for this PR in separate PR.

Rajat-Dabade commented 1 month ago

/update-branch

Rajat-Dabade commented 1 week ago

/update-branch

Rajat-Dabade commented 6 days ago

Thank you @yasserfaraazkhan for reviewing the code.

On the Draft Screen, if we hit on Android's back button (not the back arrow of MM app) the app closes instead of going back to channels list page

Let me check on this.

Once all drafts are sent out from the draft page, we have an empty page looking like below. would it be nice to add a 'No drafts at the moment' icon, like in web app. @asaadmahmood thoughts?

I remember having an empty screen for the draft view, let me add it.

Rajat-Dabade commented 6 days ago

@yasserfaraazkhan

On the Draft Screen, if we hit on Android's back button (not the back arrow of MM app) the app closes instead of going back to channels list page ✅
Once all drafts are sent out from the draft page, we have an empty page looking like below. would it be nice to add a 'No drafts at the moment' icon, like in web app. @asaadmahmood thoughts? ✅

Can you please review again? Thanks.