Closed rahimrahman closed 2 weeks ago
Have we tried everything related to files?
Have we tried everything related to files?
I have tried on Android physical device: Google Pixel 6 as many places as I can that uses react-native-file-viewer and react-native-share.
I must admit, there are a few methods I thought I traced down to the proper components (mostly file search results), but I'm not 100%.
Right now, I want @enzowritescode to validate and see if the changes make a different at all.
With that said, I'm creating the apps so that Lorenzo can download.
@rahimrahman based on our policy, we need 2 dev reviews on top of the security review.
@larkox @enahum adding you all for code review.
But I am going to work with @yasserfaraazkhan to identify all the places that uses react-native-share and react-native-file-viewer. My problem right now is I don't have enough confidence that I'm testing all the instances of Share.open() or FileViewer.open().
I've been able to report problem from MM Beta app. Didn't work very well from locally running app:
Able to share from the outside of the app into Mattermost:
https://github.com/user-attachments/assets/cd788adc-2e8c-44a7-b38b-86fa0fad1000
@yasserfaraazkhan I'm going to continue testing and find out where else react-native-share and react-native-file-viewer is being used, other than Report a Problem (react-native-share).
But if you can run the app and do some file opening and sharing, that would be great too. Particularly, opening a file and probably downloading it to your local android device (internal or external SD).
@yasserfaraazkhan I'm going to continue testing and find out where else react-native-share and react-native-file-viewer is being used, other than Report a Problem (react-native-share).
But if you can run the app and do some file opening and sharing, that would be great too. Particularly, opening a file and probably downloading it to your local android device (internal or external SD).
The gallery, to download and share the files / media
The gallery, to download and share the files / media
When you say gallery, you meant when you click on an image in certain post, and then it opens up Photo/Gallery view, then you have the option to download or share it, right?
The gallery, to download and share the files / media
When you say gallery, you meant when you click on an image in certain post, and then it opens up Photo/Gallery view, then you have the option to download or share it, right?
Yes
I did find the "Download" from the bottom sheet is not working (on .mp4). But this is an existing problem, as this demo video is from latest MM mobile app on Android.
I can create a new ticket to address this issue.
https://github.com/user-attachments/assets/c124b0af-ed42-4623-8de9-7baabda8c838
@rahimrahman if it is an existing issue then we should just create a separate ticket.
Merging but the issue with downloading movie files on MM Android app is on this ticket: https://mattermost.atlassian.net/browse/MM-61694
/cherry-pick release-2.22
Cherry pick is scheduled.
Summary
See ticket.
Ticket Link
https://mattermost.atlassian.net/browse/MM-60638 https://mattermost.atlassian.net/browse/MM-60637
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on: Android Google Pixel 6
Screenshots
Release Note