mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.26k stars 1.37k forks source link

fix(MM-60638): Provider Paths #8294

Closed rahimrahman closed 2 weeks ago

rahimrahman commented 3 weeks ago

Summary

See ticket.

Ticket Link

https://mattermost.atlassian.net/browse/MM-60638 https://mattermost.atlassian.net/browse/MM-60637

Checklist

Device Information

This PR was tested on: Android Google Pixel 6

Screenshots

Release Note

enahum commented 3 weeks ago

Have we tried everything related to files?

rahimrahman commented 3 weeks ago

Have we tried everything related to files?

I have tried on Android physical device: Google Pixel 6 as many places as I can that uses react-native-file-viewer and react-native-share.

I must admit, there are a few methods I thought I traced down to the proper components (mostly file search results), but I'm not 100%.

Right now, I want @enzowritescode to validate and see if the changes make a different at all.

With that said, I'm creating the apps so that Lorenzo can download.

esarafianou commented 3 weeks ago

@rahimrahman based on our policy, we need 2 dev reviews on top of the security review.

rahimrahman commented 3 weeks ago

@larkox @enahum adding you all for code review.

But I am going to work with @yasserfaraazkhan to identify all the places that uses react-native-share and react-native-file-viewer. My problem right now is I don't have enough confidence that I'm testing all the instances of Share.open() or FileViewer.open().

rahimrahman commented 2 weeks ago

I've been able to report problem from MM Beta app. Didn't work very well from locally running app:

Screenshot 2024-11-05 at 2 29 21 PM

Able to share from the outside of the app into Mattermost:

https://github.com/user-attachments/assets/cd788adc-2e8c-44a7-b38b-86fa0fad1000

rahimrahman commented 2 weeks ago

@yasserfaraazkhan I'm going to continue testing and find out where else react-native-share and react-native-file-viewer is being used, other than Report a Problem (react-native-share).

But if you can run the app and do some file opening and sharing, that would be great too. Particularly, opening a file and probably downloading it to your local android device (internal or external SD).

enahum commented 2 weeks ago

@yasserfaraazkhan I'm going to continue testing and find out where else react-native-share and react-native-file-viewer is being used, other than Report a Problem (react-native-share).

But if you can run the app and do some file opening and sharing, that would be great too. Particularly, opening a file and probably downloading it to your local android device (internal or external SD).

The gallery, to download and share the files / media

rahimrahman commented 2 weeks ago

The gallery, to download and share the files / media

When you say gallery, you meant when you click on an image in certain post, and then it opens up Photo/Gallery view, then you have the option to download or share it, right?

enahum commented 2 weeks ago

The gallery, to download and share the files / media

When you say gallery, you meant when you click on an image in certain post, and then it opens up Photo/Gallery view, then you have the option to download or share it, right?

Yes

rahimrahman commented 2 weeks ago

I did find the "Download" from the bottom sheet is not working (on .mp4). But this is an existing problem, as this demo video is from latest MM mobile app on Android.

I can create a new ticket to address this issue.

https://github.com/user-attachments/assets/c124b0af-ed42-4623-8de9-7baabda8c838

enahum commented 2 weeks ago

@rahimrahman if it is an existing issue then we should just create a separate ticket.

rahimrahman commented 2 weeks ago

Merging but the issue with downloading movie files on MM Android app is on this ticket: https://mattermost.atlassian.net/browse/MM-61694

amyblais commented 2 weeks ago

/cherry-pick release-2.22

mattermost-build commented 2 weeks ago

Cherry pick is scheduled.