search

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native
https://about.mattermost.com/
Apache License 2.0
2.26k stars 1.37k forks source link

fix screen position for server / login / forgot password & mfa #8340

Closed enahum closed 5 days ago

enahum commented 1 week ago

Summary

Fixes the scrolling of the contents of the following screens on iPhone, iPad & Android as part of broken window fixes

Ticket Link

https://mattermost.atlassian.net/browse/MM-56150

Fixes: #8291

Release Note

NONE
enahum commented 6 days ago

@matthewbirtch is not related to this PR but here is the thing, I can tell you for a fact that enforcing the MFA before the user has logged in, on mobile is not implemented, so the server will return the error and the mobile app will not handle it by requesting the MFA from the user. so you can try it if you enable MFA before logging in.

Yes, we should create a ticket when MFA is enforced after the user has logged in.

enahum commented 6 days ago

https://mattermost.atlassian.net/browse/MM-61834

matthewbirtch commented 6 days ago

@matthewbirtch is not related to this PR but here is the thing, I can tell you for a fact that enforcing the MFA before the user has logged in, on mobile is not implemented, so the server will return the error and the mobile app will not handle it by requesting the MFA from the user. so you can try it if you enable MFA before logging in.

Yes, we should create a ticket when MFA is enforced after the user has logged in.

Yep, confirmed I was able to test the MFA token screen now after going through he MFA setup on webapp first.

I'll create a ticket for adding this MFA setup screen to the mobile flow.