Fix 60879 - Githubissues

mattermost / mattermost-mobile

Next generation iOS and Android apps for Mattermost in React Native

https://about.mattermost.com/

Apache License 2.0

2.27k stars 1.38k forks source link

Fix 60879 #8344

Open larkox opened 2 weeks ago

larkox commented 2 weeks ago

Summary

Fix 60879

Ticket Link

Fix https://mattermost.atlassian.net/browse/MM-60879 Fix https://github.com/mattermost/mattermost-mobile/issues/8359

Release Note

NONE

larkox commented 2 weeks ago

@enahum From what I have tested, filenames usually are not encoded, so they don't need decoding.

On the other hand (and this is mostly a guess) links should be encoded, and it makes sense to decode them to get the file name.

enahum commented 2 weeks ago

@enahum From what I have tested, filenames usually are not encoded, so they don't need decoding.

On the other hand (and this is mostly a guess) links should be encoded, and it makes sense to decode them to get the file name.

Can you try a pdf file with spaces attached to a post.. I'm sure there is a reason why it was done this way at some point.. I just don't remember why it was

larkox commented 2 days ago

After my testing, I think everything should be handled correctly, but further testing is always welcomed.

@yasserfaraazkhan As testing notes:

Try uploading and dowloading normal files, from different types
Try some of those files with % in their names
Try also markdown images with % in their links
And finally, try markdown images with % in their links within a table