Open fxnm opened 5 days ago
Hello @fxnm,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
I also would recommend, that the padding of the AttachmentImage
should be unified for a even spaced border around the image component.
Please review, this is a high priority for one of our paying customers
Summary
Fixed the overflow if a message attachment is wider than the Viewport. (https://developers.mattermost.com/integrate/reference/message-attachments/#images) This is done by modifying the
getViewPortWidth
and introducing a newVIEWPORT_IMAGE_ATTACHMENT_OFFSET
. The value of it is calculated with the padding of theMessageAttachment
component (2 * 12) + the padding of theAttachmentImage
component (2,5 + 5) => 31,5https://github.com/mattermost/mattermost-mobile/blob/9b450cf68b60b47ebcb4ca84af9cc07293397567/app/components/post_list/post/body/content/message_attachments/message_attachment.tsx#L42
https://github.com/mattermost/mattermost-mobile/blob/9b450cf68b60b47ebcb4ca84af9cc07293397567/app/components/post_list/post/body/content/message_attachments/attachment_image/index.tsx#L26-L28
Ticket Link
None
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on:
Screenshots
Example Attachment
Release Note