search

mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
34 stars 29 forks source link

[MM-48916] Don't try to fet bindings from disabled apps #409

Closed hanzei closed 1 year ago

hanzei commented 1 year ago

Summary

This PR fixes a regression introduced in https://github.com/mattermost/mattermost-plugin-apps/pull/336.

I don't think it's reasonable to add a test here as it's only about the logging.

Ticket Link

https://mattermost.atlassian.net/browse/MM-48916

mickmister commented 1 year ago

@hanzei Can we harden this logic across the codebase a bit more? Maybe by default only return enabled Apps from the store, and have a separate "inconvenient" sounding function GetAppsIncludeDisabled. It depends on how often we want to do some operation with the disabled apps.