Closed javaguirre closed 1 year ago
Base: 20.73% // Head: 20.72% // Decreases project coverage by -0.01%
:warning:
Coverage data is based on head (
c27424d
) compared to base (461e9e6
). Patch coverage: 20.00% of modified lines in pull request are covered.:exclamation: Current head c27424d differs from pull request most recent head e47e0e3. Consider uploading reports for the commit e47e0e3 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Today I've been thinking I'm gonna close this PR and start from scratch. After talking this week to @hanzei this is what makes more sense IMO.
Summary
This PR does two things:
store.Get
can't be used if the app is DisabledI'm not sure about the performance of this solution, I need to get more context, let me know if you see something that might be dangerous.
Let me know if you want to separate these two solutions on different PRs or if we don't want to implement one or the other yet.
Ticket Link
https://mattermost.atlassian.net/browse/MM-40012