mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
34 stars 29 forks source link

[MM-40012] revoke access when app disabled #430

Closed javaguirre closed 1 year ago

javaguirre commented 1 year ago

Summary

This PR does two things:

I'm not sure about the performance of this solution, I need to get more context, let me know if you see something that might be dangerous.

Let me know if you want to separate these two solutions on different PRs or if we don't want to implement one or the other yet.

Ticket Link

https://mattermost.atlassian.net/browse/MM-40012

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.73% // Head: 20.72% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (c27424d) compared to base (461e9e6). Patch coverage: 20.00% of modified lines in pull request are covered.

:exclamation: Current head c27424d differs from pull request most recent head e47e0e3. Consider uploading reports for the commit e47e0e3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #430 +/- ## ========================================== - Coverage 20.73% 20.72% -0.01% ========================================== Files 80 80 Lines 5310 5312 +2 ========================================== Hits 1101 1101 - Misses 4080 4082 +2 Partials 129 129 ``` | [Impacted Files](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/proxy/enable.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2VuYWJsZS5nbw==) | `4.41% <0.00%> (ø)` | | | [server/proxy/install.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2luc3RhbGwuZ28=) | `0.00% <0.00%> (ø)` | | | [server/proxy/uninstall.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L3VuaW5zdGFsbC5nbw==) | `0.00% <0.00%> (ø)` | | | [server/store/apps.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3N0b3JlL2FwcHMuZ28=) | `0.00% <0.00%> (ø)` | | | [server/proxy/list.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2xpc3QuZ28=) | `4.21% <33.33%> (ø)` | | | [server/session/session.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Nlc3Npb24vc2Vzc2lvbi5nbw==) | `62.06% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

javaguirre commented 1 year ago

Today I've been thinking I'm gonna close this PR and start from scratch. After talking this week to @hanzei this is what makes more sense IMO.