mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
33 stars 29 forks source link

[MM-50268] Add additional fields to HTTP logger #451

Closed hanzei closed 1 year ago

hanzei commented 1 year ago

Summary

This PR adds the HTTP method, the URL and the user agent to the HTTP request logger.

The logger now logs the message before handling the request. Take makes debugging easier as the flow is more natural.

Screenshot from 2023-02-02 11-43-09

Ticket Link

https://mattermost.atlassian.net/browse/MM-50268

hanzei commented 1 year ago

I thought about removing the duplicate path field but kept it as it's useful to have that information in the other log messages down the stack.

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.74% // Head: 20.74% // No change to project coverage :thumbsup:

Coverage data is based on head (29fa5db) compared to base (76a4501). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #451 +/- ## ======================================= Coverage 20.74% 20.74% ======================================= Files 80 80 Lines 5366 5366 ======================================= Hits 1113 1113 Misses 4114 4114 Partials 139 139 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.