mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
34 stars 29 forks source link

[MM-50269] Show app icons for disabled apps #452

Closed hanzei closed 1 year ago

hanzei commented 1 year ago

Summary

Fix a regression introduced in https://github.com/mattermost/mattermost-plugin-apps/pull/336 that blocked disabled apps from showing their icon.

Ticket Link

https://mattermost.atlassian.net/browse/MM-50269

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.33% // Head: 20.33% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (d7f37f2) compared to base (7670ef9). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head d7f37f2 differs from pull request most recent head 9e407e0. Consider uploading reports for the commit 9e407e0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #452 +/- ## ======================================= Coverage 20.33% 20.33% ======================================= Files 78 78 Lines 5262 5261 -1 ======================================= Hits 1070 1070 + Misses 4062 4061 -1 Partials 130 130 ``` | [Impacted Files](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/proxy/invoke\_static.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2ludm9rZV9zdGF0aWMuZ28=) | `21.87% <0.00%> (+0.66%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hanzei commented 1 year ago

/update-branch

hanzei commented 1 year ago

/update-branch