codecov-commenter
commented
1 year ago Codecov Report
Base: 20.33% // Head: 20.31% // Decreases project coverage by -0.02% :warning:
Coverage data is based on head (
f7339cf) compared to base (a141b16). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #454 +/- ## ========================================== - Coverage 20.33% 20.31% -0.02% ========================================== Files 78 78 Lines 5261 5266 +5 ========================================== Hits 1070 1070 - Misses 4061 4066 +5 Partials 130 130 ``` | [Impacted Files](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/proxy/invoke\_static.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2ludm9rZV9zdGF0aWMuZ28=) | `18.91% <0.00%> (-2.96%)` | :arrow_down: | | [server/proxy/list.go](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2xpc3QuZ28=) | `4.21% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Summary
When a lambda cold starts, the first request invocation takes longer than usual. This causes issues with the
/pingcalls as the timeout is quite tied.This PR increases the pin timeout for lambda functions to five seconds. In my testing, an E2E install call (which includes a
/pingcall) took 2-3 seconds with a freshly deployed lambda.I've also increased the timeout for other
/pingcalls from one second to two seconds, as the former was not enough for slow and long HTTP connections.Ticket Link
https://mattermost.atlassian.net/browse/MM-49992