search

mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
34 stars 29 forks source link

Initial commit with CI file #460

Closed toninis closed 1 year ago

toninis commented 1 year ago

Summary

Migrate CI/CD from CircleCI to Github Actions

Used Golang 1.19 since tests are broken with 1.18 . Check here. I am open for suggestions here

Ticket Link

https://mattermost.atlassian.net/browse/CLD-5248

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.61 :warning:

Comparison is base (72fbf7a) 20.75% compared to head (df73c16) 20.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #460 +/- ## ========================================== - Coverage 20.75% 20.15% -0.61% ========================================== Files 80 80 Lines 5455 6600 +1145 ========================================== + Hits 1132 1330 +198 - Misses 4191 5138 +947 Partials 132 132 ``` [see 79 files with indirect coverage changes](https://codecov.io/gh/mattermost/mattermost-plugin-apps/pull/460/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mickmister commented 1 year ago

This is a lot of configuration that will be duplicated across several plugin I presume. Is there a way we can be more DRY and share the bulk of this in a common repo?

toninis commented 1 year ago

This is a lot of configuration that will be duplicated across several plugin I presume. Is there a way we can be more DRY and share the bulk of this in a common repo?

This is part of our work . We are going to create reusable actions across the company for consistency . We will get there 😄 Feel free thought o experiment .