search

mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
34 stars 29 forks source link

[GH-22474] Support updating bot display name from app manifest #466

Closed mujpao closed 1 year ago

mujpao commented 1 year ago

Summary

This pull request supports updating the display name and description of an app's associated bot account to match the app's display name when the app is reinstalled.

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/22474

mattermost-build commented 1 year ago

Hello @mujpao,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (de487d6) 20.16% compared to head (86ebe20) 20.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #466 +/- ## ========================================== - Coverage 20.16% 20.11% -0.05% ========================================== Files 80 80 Lines 6612 6628 +16 ========================================== Hits 1333 1333 - Misses 5147 5163 +16 Partials 132 132 ``` | [Files](https://app.codecov.io/gh/mattermost/mattermost-plugin-apps/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/proxy/install.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-apps/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3Byb3h5L2luc3RhbGwuZ28=) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mujpao commented 1 year ago

I added a test in a new file. Is this the right way to do this?

mattermost-build commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hanzei commented 1 year ago

/update-branch

hanzei commented 1 year ago

Skipping QA testing as the changes are tested by e2e tests