search

mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
33 stars 29 forks source link

Remove reference to prod rudder key in ci workflow, keep in cd workflow #470

Closed mickmister closed 1 year ago

mickmister commented 1 year ago

Summary

Using the prod Rudderstack telemetry key in CI can skew our telemetry numbers. The production builds of the plugin produced by the cd.yml should still contain the prod key. This PR We makes it so we use the development key instead for the ci.yml workflow.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-apps/issues/469

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (6287cd5) 20.15% compared to head (433bdcd) 20.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #470 +/- ## ======================================= Coverage 20.15% 20.15% ======================================= Files 80 80 Lines 6600 6600 ======================================= Hits 1330 1330 Misses 5138 5138 Partials 132 132 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.