Closed kyeongsoosoo closed 11 months ago
Hello @kyeongsoosoo,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Patch coverage: 100.00%
and project coverage change: +0.03%
:tada:
Comparison is base (
89a1e4c
) 20.12% compared to head (6a56b64
) 20.16%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/update-branch
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Summary
When the
InvokeCall
method is executed,AppContext
is assigned an expanded context. https://github.com/mattermost/mattermost-plugin-apps/blob/89a1e4c1fd9e784a52129266e7021b72fc813100/server/proxy/invoke_call.go#L185-L190I found that the
user_agent
field disappears becauseexpandContext
method initializes theUserAgentContext
when it runs. I changed theuser_agent
andtrack_as_submit
fields to keep their original values on initialization. https://github.com/mattermost/mattermost-plugin-apps/blob/89a1e4c1fd9e784a52129266e7021b72fc813100/server/proxy/expand.go#L216-L217Ticket Link
Fixes https://github.com/mattermost/mattermost/issues/23621 JIRA https://mattermost.atlassian.net/browse/MM-53015