mattermost / mattermost-plugin-apps

Powers the Mattermost App Framework
https://developers.mattermost.com/integrate/apps/
Apache License 2.0
33 stars 29 forks source link

#25169 Apps Framework README > Split out admin content to child pages #481

Closed Reene-Simon closed 10 months ago

Reene-Simon commented 10 months ago

Summary

This PR organizes the README section as per the instructions in the issue description. I have used the reviews given for a similar issue, namely the Bitbucket README and have tried to incorporate the instructions given by the reviewers. These are the main changes that have been done:

  1. Created a table of contents as mentioned
  2. Made a new admin-guide file under the docs folder
  3. Moved all configuration details into the admin-guide file
  4. Linked all the links and the table of contents according to the changes made

Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/25169

mattermost-build commented 10 months ago

Hello @Reene-Simon,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c0be1b2) 20.11% compared to head (d09066d) 20.11%.

:exclamation: Current head d09066d differs from pull request most recent head c49a93c. Consider uploading reports for the commit c49a93c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #481 +/- ## ======================================= Coverage 20.11% 20.11% ======================================= Files 80 80 Lines 6628 6628 ======================================= Hits 1333 1333 Misses 5163 5163 Partials 132 132 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Reene-Simon commented 10 months ago

@cwarnermm @mickmister I have made the requested changes. Please do review it.

mickmister commented 10 months ago

Approving assuming the above change is done

Reene-Simon commented 10 months ago

@cwarnermm @mickmister I have made the relevant changes. Do check it out