search

mattermost / mattermost-plugin-calls

https://www.mattermost.com
Other
96 stars 55 forks source link

Header Button Lacks Icon on Mobile Web #780

Open ckaznable opened 3 months ago

ckaznable commented 3 months ago

The primary reason for this issue is that the registerCallButtonAction method dispatches both CallButton and MobileChannelHeaderButton simultaneously but does not pass an icon, resulting in this behavior.

Additionally, I have also opened a related issue in the Mattermost repository. https://github.com/mattermost/mattermost/issues/27359

screenshot: image

streamer45 commented 3 months ago

@ckaznable I don't believe web view should be a supported way to use this functionality from mobile. It may work, but it wasn't part of the design.

@cpoile @matthewbirtch Thoughts?

cpoile commented 3 months ago

I agree.. Perhaps we should not register it on mobile web?

ckaznable commented 3 months ago

I just checked community.mattermost.com and did not encounter the same issue. Perhaps it's just a configuration issue on my end?

streamer45 commented 3 months ago

@ckaznable Could you share a screenshot of how it would look like when working? I don't remember having a button to start calls in that view.

ckaznable commented 3 months ago

when I press this button, it triggers the plugin's behavior. After disabling the plugin, the button no longer appears, so I'm sure it's the button from this plugin.

image

matthewbirtch commented 3 months ago

@ckaznable I don't believe web view should be a supported way to use this functionality from mobile. It may work, but it wasn't part of the design.

@cpoile @matthewbirtch Thoughts?

Agreed, plugin actions were not intended to show in the header on mobile web view.

ckaznable commented 3 months ago

When I use the desktop version and reduce the screen width, this situation also occurs. I think this is not limited to mobile web.

streamer45 commented 3 months ago

Yes, that's exactly the same view, regardless of the device.