search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
156 stars 145 forks source link

Use official GitHub icons #268

Closed larkox closed 3 years ago

larkox commented 4 years ago

We are using a few SVGs under webapp/src/images/icons that correspond to the Github icons. These and other Github icons are published in a npm package (https://primer.style/octicons/). We should use this package instead of the SVGs on webapp/src/images/icons.

AugustasV commented 4 years ago

I would like to work on this issue! Any tips would be appreciated!

larkox commented 4 years ago

Thanks @AugustasV ! It is yours. If you need any help, feel free to ask. Regarding tips, you can take a look to this PR. There the contributor added the npm package and used some icons from the package. Since it is already merged, you will not need to import the package again. Just use it on the right places.

AugustasV commented 4 years ago

Great! @larkox Made changes according Octicons plugin documentation, not sure if it's correct - didin't know how to test it.