search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 150 forks source link

Notifications do not respect organization lock #282

Open DHaussermann opened 4 years ago

DHaussermann commented 4 years ago

When the plugin is configured to be locked to a specific repo, a user can still receive notifications from at mentions is other repos

This may not necessarily be a bug but it is not consistent with the To do list and other functionality of the plugin. This does not appear to be a regression from the current release.

  1. Connect tests user
  2. Lock the plugin to specific organization
  3. As a different GitHub user at mention the test user in a different org or account

Observed: Notifications are delivered from the bot

hanzei commented 4 years ago

When the plugin is configured to be locked to a specific repo, a user can still receive notifications from at mentions is other repos

To be clear: Are you talking about repos here or about organisations?

If you are talking about organisations, then I can't reproduce your issue.

  1. Connect user1
  2. Connect user2
  3. Lock to organization "abc"
  4. Let user1 post a comment in a repo that is not in "abc" and @-mention user2

Observed: user2 doesn't get a notification