Include "number of lines changed" in RHS PR list

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost

Apache License 2.0

157 stars 148 forks source link

Include "number of lines changed" in RHS PR list #468

Open mickmister opened 3 years ago

mickmister commented 3 years ago

Currently the right-hand side display of PRs looks like this:

It would be useful to know the magnitude of the PR when browsing, so it's obvious how long it might take to review the PR.

mickmister commented 3 years ago

@matthewbirtch Can I assign this ticket to you or another designer for UX design?

matthewbirtch commented 3 years ago

@mickmister can you create a Jira ticket describing the problem we're trying to solve and assign to the UX Team? We'll triage it from there.

I would think the number of files and lines changed would be useful

mickmister commented 3 years ago

Thanks @matthewbirtch, I've created the ticket here https://mattermost.atlassian.net/browse/MM-37789

I would think the number of files and lines changed would be useful

Absolutely! I've added this to the ticket

matthewbirtch commented 3 years ago

Thanks @mickmister!

raghavaggarwal2308 commented 2 months ago

@mickmister can you create a Jira ticket describing the problem we're trying to solve and assign to the UX Team? We'll triage it from there.

I would think the number of files and lines changed would be useful

@matthewbirtch Can you please tell us the status of this?

matthewbirtch commented 2 months ago

@mickmister can you create a Jira ticket describing the problem we're trying to solve and assign to the UX Team? We'll triage it from there. I would think the number of files and lines changed would be useful

@matthewbirtch Can you please tell us the status of this?

@raghavaggarwal2308 this fell through the cracks a long time ago. Is this something your team is wanting to work on? I can queue this up for my team to put some designs together.

raghavaggarwal2308 commented 2 months ago

@matthewbirtch Yes, we were planning to work on it for our upcoming release

matthewbirtch commented 2 months ago

Okay @asaadmahmood is going to review this and work on some designs. What is the timing for the upcoming release?

raghavaggarwal2308 commented 2 months ago

Okay @asaadmahmood is going to review this and work on some designs. What is the timing for the upcoming release?

@matthewbirtch I think it will be around mid of August.

raghavaggarwal2308 commented 2 weeks ago

@matthewbirtch Are there any updates on this?

matthewbirtch commented 2 weeks ago

@raghavaggarwal2308 I don't think @asaadmahmood was able to prioritize this with all that's on his plate right now. One of us will look at this and will get back to you as soon as we can - early next week ideally. Apologies for the delay.

asaadmahmood commented 2 weeks ago

@raghavaggarwal2308 Here's what it would look like. Also note the other icon improvements and spacing adjustments to make the content a bit more digestable. https://www.figma.com/design/YMvnd2wc5ibnrqIPObZjMY/Github-RHS?node-id=511-9369&node-type=FRAME&t=lddqIPe3gDWHmcaI-11

I'm using Github's own icons for the icons: https://primer.style/foundations/icons/

If adding the dynamic boxes after the + / - numbers like Github is not possible, we can omit the boxes and just show the + / - count.

raghavaggarwal2308 commented 1 week ago

@matthewbirtch @asaadmahmood Thanks! we will work on the same