search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 150 forks source link

unusable links in plugin messages #693

Closed ChristophHoyer closed 11 months ago

ChristophHoyer commented 1 year ago

Hej there!

Whenever I get a notification from the Mattermost-GitHub plugin it includes links to nowhere. image

The slash in front of the message just leads to https://.com// image

And when I click on the message, it gets a warning about a missing app for "about" links in the desktop app and only opens a "about:blank#blocked" page in the browser. image

Kshitij-Katiyar commented 1 year ago

@ChristophHoyer I am unable to reproduce the above issue. Please share your build version, mattermost server version, and any other detail relevant to this issue.

ChristophHoyer commented 1 year ago

sure, here you go:

Mattermost Enterprise Edition
Modern communication from behind your firewall.

Mattermost Version: 7.8.9
Database Schema Version: 107
Database: mysql
Licensed to: XXXXXXXXXXXXXXXXXX
Learn more about Enterprise Edition at [mattermost.com](https://mattermost.com/)
Copyright 2015 - 2023 Mattermost, Inc. All rights reserved
[Terms of Use](https://mattermost.com/terms-of-use/) - [Privacy Policy](https://mattermost.com/privacy-policy/)
Mattermost is made possible by the open source software used in our [server](https://github.com/mattermost/mattermost-server/blob/master/NOTICE.txt), [desktop](https://github.com/mattermost/desktop/blob/master/NOTICE.txt) and [mobile](https://github.com/mattermost/mattermost-mobile/blob/master/NOTICE.txt) apps.

Build Hash: 6c6da2672849c1f0ca41efec67bea8391615cd69
EE Build Hash: 2238ac8bcac3dc0a95ca5330c5c3288282b13c38
Webapp Build Hash: 65aaab5fbf802cd64b8093c1b180ee23593e0cc3
Build Date: Mon Jul 24 10:29:41 UTC 2023

By the way: the first link should lead to an action run, the second one to a discussion. Links to issues or pull requests are working on my side as well.